Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added MDX example #223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: added MDX example #223

wants to merge 2 commits into from

Conversation

muningis
Copy link

@muningis muningis commented Dec 18, 2024

https://github.com/kentcdodds/mdx-bundler (still waiting for 10.2.0 with my fix on my mistake..)

Unfortunately, this can not be used in Cloudflare Workes as mdx-bundler depends on esbuild :(


This is how hello-world.mdx get's rendered:
image

@muningis muningis changed the title draft: feat: added MDX example feat: added MDX example Feb 10, 2025
@muningis
Copy link
Author

@yusukebe Please check when you're available

@yusukebe
Copy link
Member

Hi @muningis

This is interesting, and I'm glad I can learn about mdx-bundler. But I think this example is not suited for honojs/examples. Because examples should be simple and for general use cases. My idea is to put this content on the Example page of our website: https://hono.dev/examples/.

@muningis
Copy link
Author

examples should be simple and for general use cases.
Yeah, I had similar concern/doubt, but tbh this isn't that much more complicated compared to, for example, blog example -> https://github.com/honojs/examples/tree/main/blog or examples in https://hono.dev/examples/.

As a comparison, I could provide example suited in style of https://hono.dev/examples/ to see whether it's suited and/or too complicated?

@yusukebe
Copy link
Member

@muningis

Okay! I think you may know but you should focus "How to use mdx-bundler with Hono".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants